DooPHP IRC channel


Extra code in DooSession::isStarted()

Discussion about weird behaviors of DooPHP.

Extra code in DooSession::isStarted()

Postby roman » Thu Feb 09, 2012 6:29 am

Revision r696 has this code:

Code: Select all
if (!empty($_SESSION[$this->_namespace]) && $this->_sessionStarted)


The first check is unnecessary because both are set in the start() method. The second condition is sufficient and probably faster than the first one.
roman
 
Posts: 442
Joined: Sat Aug 01, 2009 8:31 pm

Re: Extra code in DooSession::isStarted()

Postby roman » Wed Feb 22, 2012 9:10 pm

It looks like this framework doesn't have much to look forward to. The committers are busy, bug reports go unnoticed for weeks... It's a pity.
roman
 
Posts: 442
Joined: Sat Aug 01, 2009 8:31 pm

Re: Extra code in DooSession::isStarted()

Postby donkapone » Sun Feb 26, 2012 10:16 am

I'm also saddened by this situation. I'd be happy to commit some code fixing some bugs, if I had the opportunity...
donkapone
 
Posts: 27
Joined: Fri Jun 17, 2011 4:46 pm

Re: Extra code in DooSession::isStarted()

Postby roman » Tue Feb 28, 2012 5:24 am

Then let's ask Leng and/or Richard to add us to the list of committers.
roman
 
Posts: 442
Joined: Sat Aug 01, 2009 8:31 pm

Re: Extra code in DooSession::isStarted()

Postby donkapone » Tue Feb 28, 2012 6:19 am

Let's.
donkapone
 
Posts: 27
Joined: Fri Jun 17, 2011 4:46 pm

Re: Extra code in DooSession::isStarted()

Postby leng » Thu Mar 01, 2012 4:59 pm

done. added you both.
Just Doo IT!
leng
 
Posts: 1482
Joined: Thu Jul 16, 2009 11:33 pm


Return to Bugs Report

Who is online

Users browsing this forum: No registered users and 0 guests

cron