Diagnostics needs improvement

[roman]

Current implementation of diagnostics isn't very useful. Display for most, if not all, exceptions contains the correct message of the exception, but everything else is not shown. PHPTAL library I use throws exceptions with information about template files where a problem occurred (file name, line number, etc.). However, DooPHP's diagnostics displays only the line where exception was caught, in addition to the short message itself:

Code: Select all

Doo::app()->run();

To get more detailed information, I've been temporarily turning off DooPHP's diagnostics, and I would like it to be improved to display all pieces of information in exceptions thrown.

[leng]

Could you attach a sample project with PHPTAL that throws the exception? I will see how to make it more useful by utilising the exception's message.

[roman]

Leng, I attached a zip file with everything you need to run a test (PHPTAL library, a test PHP script, and a template). It's not a DooPHP based test, so put the PHP code into any DooPHP demo app to test.

[roman]

The idea is to have all pieces of available potentially useful information displayed, not to have DooPHP diagnostics tailor made for exceptions thrown by PHPTAL library because the library may change the way it does things, and I and other people will deal with other types of exceptions.

[leng]

It currently prints out the exception message and print the stack trace out in details.
I wonder what you have in mind on improving the diagnostic view. As for me, I would really want it to print_r() the exception so I can have all the details for debugging.

[roman]

That's what I want too -- all the details. Look at the attached screenshot of what I get currently. There's some useful info displayed there, but sometimes it's not enough.

[Mil0s]

I am getting this error:

Notice: ob_clean() [ref.outcontrol]: failed to delete buffer. No buffer to delete. in /var/web/milos/starflirt-admin/dooframework/diagnostic/debug.php on line 137
DooPHP
ob_clean() [ref.outcontrol]: failed to delete buffer. No buffer to delete.

[RichardM]

Hi Mil0s,

If you update to the latest version of DooPHP from SVN I have applied a fix for this. Actually I applied the fix twice but it got lost in another update at some point. Just checked and it seems to be in the latest revision I have checked out.


Richard

[Mil0s]

Ohh, tnx Richard I will download new trunk

[roman]

Improvement in this area would be a good New Year present